Using boolean variables as flags, exposes accidental implementation and pollutes the code with Ifs.

TL;DR: Don't use boolean variables, they force you to write Ifs. Create polymorphic states instead.

Problems

• Extensibility

• Comparison in some languages

Solutions

• If Boolean maps to a real world entity is safe. Otherwise, model as a State to favor Extensibility. This also follows Open/Closed Principle.

Examples

• Flags

Exceptions

• Real world true/false rules

Sample Code

Wrong

<?

function processBatch(
    bool $useLogin,
    bool $deleteEntries,
    bool $beforeToday) {
    //...
}

Right

<?

function processBatch(
    LoginStrategy $login,
    DeletionPolicy $deletionPolicy,
    Date $cutoffDate) {
    //...
}

Detection

Automatic detection can warn for boolean usage, but this can yield false positives.

Relations

Some languages have issues with boolean comparators.

In these coupled with accidental complexity languages, booleans are a common error source.

Also Known as

• Flag Abuser

Tags

• Declarative

• Primitive

More info

Martin Fowler

Conclusion

Take extra care when declaring something boolean. Flags are difficult to maintain and extend.
Learn more about the domain. Try migrating to state design pattern. Use polymorphism instead of ifs/switch/cases.

Credits

Photo by Phil Hearing on Unsplash

These tweets inspired this code smell:

This article is part of the CodeSmell Series.

How to Find the Stinky parts of your Code

Maxi Contieri ・ May 21 '21

#codenewbie #tutorial #codequality #beginners

Last update: 2021/06/08